Skip to content

FIX: analyze_from_zero #6425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Oct 29, 2025
Merged

FIX: analyze_from_zero #6425

merged 32 commits into from
Oct 29, 2025

Conversation

@anur7
Copy link
Contributor

@anur7 anur7 commented Jul 17, 2025

Description

This PR fixes the bug in analyze_from_zero() method in maxwell.py.
The missing unit test of the will also be added in this PR.

Issue linked

Issue #6404

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@anur7 anur7 self-assigned this Jul 17, 2025
@anur7 anur7 added the bug Something isn't working label Jul 17, 2025
@ansys-reviewer-bot
Copy link
Contributor

ansys-reviewer-bot bot commented Jul 17, 2025

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@anur7 anur7 linked an issue Jul 17, 2025 that may be closed by this pull request
Bug located in analyze_from_zero() #6404
Closed
2 tasks
@codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.49%. Comparing base (51a6d85) to head (c07d4d4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6425   +/-   ##
=======================================
  Coverage   83.48%   83.49%           
=======================================
  Files         245      245           
  Lines       77503    77506    +3     
=======================================
+ Hits        64706    64716   +10     
+ Misses      12797    12790    -7
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anur7 anur7 requested review from gmalinve and nunesanderson July 18, 2025 22:04
@anur7 anur7 marked this pull request as ready for review July 18, 2025 22:10
@anur7 anur7 requested a review from a team as a code owner July 18, 2025 22:10
@anur7 anur7 requested a review from jvela018 July 21, 2025 08:29
nunesanderson
nunesanderson previously requested changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@nunesanderson nunesanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmalinve I will leave it to you to approve it.
Thanks @anur7 for fixing the issue.

gmalinve
gmalinve reviewed Jul 21, 2025
View reviewed changes
gmalinve
gmalinve reviewed Jul 21, 2025
View reviewed changes
gmalinve
gmalinve reviewed Jul 21, 2025
View reviewed changes
gmalinve
gmalinve requested changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anur7 see my comments.

gmalinve
gmalinve reviewed Jul 21, 2025
View reviewed changes
gmalinve
gmalinve reviewed Jul 21, 2025
View reviewed changes
@anur7 anur7 added the testing Anything related to testing label Aug 5, 2025
SMoraisAnsys
SMoraisAnsys reviewed Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just à minor comment

@anur7 anur7 requested a review from SMoraisAnsys August 7, 2025 10:36
@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft August 14, 2025 13:48
@gmalinve gmalinve marked this pull request as ready for review October 28, 2025 12:43
@gmalinve gmalinve assigned gmalinve and unassigned anur7 Oct 28, 2025
@gmalinve gmalinve dismissed nunesanderson’s stale review October 28, 2025 15:37

sorry, need to close this

@gmalinve gmalinve enabled auto-merge (squash) October 28, 2025 15:38
@gmalinve gmalinve merged commit 24e7c77 into main Oct 29, 2025
39 checks passed
@gmalinve gmalinve deleted the fix/analyze_from_zero branch October 29, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmalinve gmalinve gmalinve approved these changes

@jvela018 jvela018 Awaiting requested review from jvela018

@nunesanderson nunesanderson Awaiting requested review from nunesanderson

@Samuelopez-ansys Samuelopez-ansys Awaiting requested review from Samuelopez-ansys

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys

Assignees

@gmalinve gmalinve

Labels

bug Something isn't working testing Anything related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug located in analyze_from_zero()

7 participants

@anur7 @nunesanderson @gmalinve @SMoraisAnsys @pyansys-ci-bot @Samuelopez-ansys